Improve rendering of 'types' in addon-actions #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1887 +/- ##
===============================================
+ Coverage 22.22% 22.25% +0.03%
===============================================
Files 326 325 -1
Lines 6538 6520 -18
Branches 804 813 +9
===============================================
- Hits 1453 1451 -2
+ Misses 4497 4466 -31
- Partials 588 603 +15
Continue to review full report at Codecov.
|
|
|
ndelangen
changed the title
ndelangen
changed the title
Hypnosphi
reviewed
Nov 6, 2017
| @@ -113,5 +123,7 @@ export function retrocycle($) { | |||
| } | |||
| })($); | |||
|
|
|||
| muteProperty(CYCLIC_KEY, $); | |||
There was a problem hiding this comment.
@rhalff this breaks when $ is a primitive value (e.g., a string). The failure is silent because of this catch block: https://github.com/storybooks/storybook/blob/master/lib/channel-postmessage/src/index.js#L68
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the root level not rendering correctly
e.g. It now renders
[SyntheticEvent, Event]instead of[Object, Object]The
constructor.namereplacement which was done by theNodeRendereris now done immediately using thereviverfunction during JSON.parse.