Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AddContext from mdx packages #18709

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Remove AddContext from mdx packages #18709

merged 2 commits into from
Jul 18, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday requested a review from shilman July 14, 2022 06:02
@nx-cloud
Copy link

nx-cloud bot commented Jul 14, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae12b62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday changed the base branch from next to future/base July 14, 2022 11:33
@tmeasday tmeasday mentioned this pull request Jul 14, 2022
Open
@tmeasday tmeasday added maintenance User-facing maintenance tasks addon: docs labels Jul 14, 2022
@tmeasday tmeasday changed the title Remove AddTemplate from mdx packages Remove AddContext from mdx packages Jul 18, 2022
@shilman shilman self-assigned this Jul 18, 2022
shilman
shilman approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure what to do about those open PRs since this won't be released until 7.0

@shilman shilman merged commit 2a77787 into future/base Jul 18, 2022
@shilman shilman deleted the tom/sb-465-remove-call-to-addtemplate-from-mdx branch July 18, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@shilman shilman

Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman