Bump dependency to support React 18 #18701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package "react-element-to-jsx-string" was only support React <= 17. Bumping it to a newer version adds support for React 18. https://www.npmjs.com/package/react-element-to-jsx-string https://github.com/algolia/react-element-to-jsx-string
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 6b10387. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
|
Hey @eirslett-visma thanks for your contribution! Also, did you forget to update the lockfile? |
|
I noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The package "react-element-to-jsx-string" was only supporting React <= 17.
Bumping it to a newer version adds support for React 18.
https://www.npmjs.com/package/react-element-to-jsx-string
https://github.com/algolia/react-element-to-jsx-string
What I did
Bumped the dependency
How to test
If your answer is yes to any of these, please make sure to include it in your PR.