Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future - dependencies: use dequal for equality checks #18608

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

ndelangen
Copy link
Member

replaces this PR: #12451
Because I am not allowed to push to the contributor's remote..

Issue: #12433

What I did

Replaced fast-deep-equal with dequal, which is smaller (>100B) and faster.
This dequal/lite variant has an identical featureset.

How to test

No code changes. All tests (yarn test --core) pass locally.

I was asked to do a performance comparison before/after, but I've no idea how to set that up within this project.

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 997dc74. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen
Copy link
Member Author

This seems to break IE11 compatibility, but this is not a huge deal, because we're scrapping IE11 support anyway in 7.0
So this PR looks good to me

@ndelangen ndelangen changed the base branch from next to future/base July 6, 2022 17:00
# Conflicts:
#	examples/web-components-kitchen-sink/yarn.lock
#	lib/api/src/modules/layout.ts
#	lib/blocks/src/blocks/SourceContainer.tsx
@ndelangen ndelangen changed the title dependencies: use dequal for equality checks Future - dependencies: use dequal for equality checks Jul 6, 2022
@ndelangen
Copy link
Member Author

switched base branch to future/base

@ndelangen ndelangen merged commit dee7788 into future/base Jul 6, 2022
@ndelangen ndelangen deleted the luke/next branch July 6, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant