7.0.0 pnp support #18461
7.0.0 pnp support #18461
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d639aff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
If this is succesful, I'm planning of writing a auto-migration to migrate the user's main.js before running storybook. Alternatively I could investigate into: const path = require('path');
module.exports = {
'@storybook/react-webpack5': path.dirname(require.resolve(path.join(''@storybook/react-webpack5', 'package.json'))),
// ... more addons and frameworks here
}And used that file to help resolve dependencies... |
ndelangen
added
compatibility with other tools
yarn / npm
| @@ -60,9 +60,14 @@ export const exec = async ( | |||
| logger.debug(command); | |||
| return new Promise((resolve, reject) => { | |||
| const defaultOptions: ExecOptions = { | |||
| silent: true, | |||
| silent: false, | |||
| ...defaultOptions, | ||
| ...options, | ||
| async: true, | ||
| silent: false, |
…e for angular and vue remove code relating to framework detection
Codecov Report
@@ Coverage Diff @@
## future/base #18461 +/- ##
===============================================
- Coverage 30.76% 30.74% -0.02%
===============================================
Files 799 798 -1
Lines 17076 17079 +3
Branches 3526 3526
===============================================
- Hits 5253 5251 -2
- Misses 11398 11403 +5
Partials 425 425
Continue to review full report at Codecov.
|
So in order for pnp to work, we need to ensure all dependencies exist in the context they are required in.
This achieves that by using require.resolve.
The way i achieve the above is by generating the proper code into
main.js.This is ugly, but right now I just want to ensure it actually works in pnp mode.
If it does, I plan to either:
main.js) via some sort of interpreter/loader and modify the code before executing.