-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add additional files api to sb repro #18389
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4f5b90e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Seems like it changed in version 14. From --skipInstall to --skip-install
2c3c71b
to
27c8357
Compare
Codecov Report
@@ Coverage Diff @@
## next #18389 +/- ##
==========================================
- Coverage 32.05% 32.04% -0.01%
==========================================
Files 975 975
Lines 19211 19216 +5
Branches 4031 4031
==========================================
Hits 6158 6158
- Misses 12490 12494 +4
- Partials 563 564 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- any idea what's up with the codecov comments in the review mode? it's really annoying
Definitely annoying – I think the "problem" was introduced with the A11yPanel component changes from another PR: https://app.codecov.io/gh/storybookjs/storybook/compare/18389/changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💯
Issue: N/A
What I did
Added
additionalFiles
to repro config, so that we can add files before initializing Storybook.Looks like this:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.