CLI: Fix "reset" script removing .idea directory and add "cleanup" script #18309
Conversation
It also makes sure only root level directories are excluded Closes #18308
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8bdb1cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| @@ -11,8 +11,8 @@ const cleaningProcess = spawn('git', [ | |||
| 'clean', | |||
| '-xdf', | |||
| '-n', | |||
| '--exclude=".vscode"', | |||
| '--exclude=".idea"', | |||
| '--exclude="/.vscode"', | |||
There was a problem hiding this comment.
@okonet Any idea why this is necessary? This seems to be more restrictive than what was there before
There was a problem hiding this comment.
Without that it would try to match .vscode recursively which would increase the amount of directories it would output dramatically because .vscode is often present in node_modules. With the / it would only match the root directories.
There was a problem hiding this comment.
I don't even think /.vscode is needed here since it's under VCS but I left it in case it contains some user-generated settings.
There was a problem hiding this comment.
Fair enough, but I was more interested in '--exclude=".idea"', which already existed in the code and was replaced by --exclude="/.idea" which seems more restrictive
There was a problem hiding this comment.
The .idea didn't work for me at all. Thus the fix.
There was a problem hiding this comment.
That's my question. Any idea why ".idea" doesn't work but "/.idea" does?
There was a problem hiding this comment.
Not really. I would assume it could treat the . as part of regex but I didn't want to spend too much time investigating.
Issue: #18308
What I did
Fix the script to not delete
.ideaFix the wording in case when the user decides not to run the script
Add an additional script to delete
**/distonlyHow to test
Create
.ideadir in the rootRun
yarn bootstrapand selectresetAfter script has run you should still see
.ideain the root directoryRun
yarn bootstrapand selectresetscriptAnswer
Noor press Esc when asked "are you sure?"It should say
Cleanup cancelledinstead ofproblem is between keyboard and chairRun
yarn bootstrapand selectcleanupscriptIt should only delete
/distfolders inside packages and leavenode_modulesand other files intact