(docs) Updated Angular styles Nx docs #18289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d548cdf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jonniebigodes
added
documentation
patch:yes
jonniebigodes
requested changes
May 24, 2022
There was a problem hiding this comment.
@mandarini thank you very much for the time and effort you've put into this pull request and help us improve our documentation. I left a small suggestion, let me know what you think, and we'll go from there.
Hope you have a fantastic day.
Stay safe.
mandarini
force-pushed
the
docs/fix-nx-angular-docs
branch
from
ea7ef1a to
d548cdf
Compare
|
Updated based on comment! :) |
|
@mandarini thanks for taking care of the feedback so promptly. Appreciate it 🙏 . Merging the pr. |
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Documentation for Angular styles for Nx should be updated due to this change.
What I did
I updated the documentation for Angular styles for Nx. Starting Nx
14.1.8we are going to be using the@storybook/angular:start-storybookand@storybook/angular:build-storybook. That means that the configuration is going to be the same as it is in pure Storybook Angular setups. Still, the libraries need that extra documentation bit. I just updated that part!Here's the Nx PR that changed this, btw.