Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix get-monorepo-type when no package.json at repo root #18259

Merged
merged 1 commit into from
May 19, 2022
Merged

Core: Fix get-monorepo-type when no package.json at repo root #18259

merged 1 commit into from
May 19, 2022

Conversation

lifeiscontent
Copy link
Member

Fixes issues when no package.json exists at the root of a repo

Issue:

What I did

upgraded to newer version of storybook and ran into this issue

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@lifeiscontent
Update get-monorepo-type.ts
0d21b96 
Fixes issues when no package.json exists at the root of a repo
@nx-cloud
Copy link

nx-cloud bot commented May 19, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d21b96. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lifeiscontent lifeiscontent requested a review from shilman May 19, 2022 03:49
@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core telemetry labels May 19, 2022
@shilman shilman added this to the 6.5 release milestone May 19, 2022
@shilman shilman added the linear label May 19, 2022
yannbf
yannbf approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for that fix @lifeiscontent !

@shilman shilman changed the title Update get-monorepo-type.ts Core: Fix get-monorepo-type when there is no package.json at repo root May 19, 2022
@shilman shilman changed the title Core: Fix get-monorepo-type when there is no package.json at repo root Core: Fix get-monorepo-type when no package.json at repo root May 19, 2022
@shilman shilman merged commit 728b372 into next May 19, 2022
@shilman shilman deleted the lifeiscontent-patch-1 branch May 19, 2022 12:02
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 19, 2022
shilman added a commit that referenced this pull request May 19, 2022
@shilman
Merge pull request #18259 from storybookjs/lifeiscontent-patch-1
86b4754 
Core: Fix get-monorepo-type when no package.json at repo root
This was referenced May 19, 2022
Closed
Closed
@dannyhw dannyhw mentioned this pull request Nov 26, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@yannbf yannbf

Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Milestone
6.5 release
Development

Successfully merging this pull request may close these issues.
3 participants
@lifeiscontent @yannbf @shilman