Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parent wildcard sortOrder #18243

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

EloB
Copy link
Contributor

@EloB EloB commented May 17, 2022

Issue: #16573

What I did

Added ability to have parent order wildcard in storySort.

For example:

"options": {
  "storySort": {
    "includeNames": true,
    "order": [
      "Introduction",
      "*", ["Introduction", "Examples", "*"]
    ]
  }
}

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

How do you normally add test or live sandboxes for testing?

@nx-cloud
Copy link

nx-cloud bot commented May 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8fc501. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

* next: (179 commits)
  Add html framework examples for the introduction docs
  Update document to show storybook initialization using npm.
  Fix syntax error in `test-runner.md`
  Fix formatting of `docs/faq.md`
  Update whats-a-story.md
  Fix /docs 404s
  upgrade @storybook/testing-library to next
  Actually run the npm7 migration
  Small refactor
  Prevent showing child exception while parent is still playing
  Reset instrumenter state on HMR
  Use node14 in netlify
  Add a test
  Created npm7 migration
  Update addons/interactions/src/components/Interaction/Interaction.tsx
  Tweak anonymous function color
  Expand by default
  Collapse child interactions
  Better story data
  Add story book interaction row with parentId
  ...
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, @EloB! Appreciate your help to solve this issue.

@kylegach kylegach merged commit 57af527 into storybookjs:next Jun 28, 2022
@kylegach kylegach added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 28, 2022
@EloB EloB deleted the feature/wildcard-parent-sortorder branch June 28, 2022 22:31
@shilman shilman added feature request and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants