Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to telejson 6 #18164

Merged
merged 12 commits into from
May 10, 2022
Merged

Upgrade to telejson 6 #18164

merged 12 commits into from
May 10, 2022

Conversation

ndelangen
Copy link
Member

What I did

Upgrade to telejson v6

@nx-cloud
Copy link

nx-cloud bot commented May 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0e82ef6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen requested a review from shilman May 6, 2022 15:53
@ndelangen ndelangen self-assigned this May 6, 2022
@shilman shilman changed the title upgrade to telejson 6 Upgrade to telejson 6 May 6, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen Change seem to be working but e2e-core tests are failing pretty hard (on this branch only AFAICT). Can you please take a look?

@shilman
Copy link
Member

shilman commented May 9, 2022

@ndelangen now it's chromatic that's failing on IE11 support

https://www.chromatic.com/build?appId=5def62c97bd45f0020ef370e&number=11798

@ndelangen
Copy link
Member Author

Wow, I'm stuck on this... I tried all sorts of things, and angular doesn't like any of it. also seems there's still something broken in IE11...

I ran npx -p @storybook/cli sb repro ../storybook-e2e-testing/angular13 --framework angular --template angular13 --e2e locally, and verified it's using the latest version of telejson, and locally it seemed to work just fine...

@ndelangen
Copy link
Member Author

@shilman can you assist in reproducing this? I can't figure out what the problem is..

@yannbf
Copy link
Member

yannbf commented May 9, 2022

@shilman can you assist in reproducing this? I can't figure out what the problem is..

we figured out already, don't bother!

@ndelangen
Copy link
Member Author

@shilman final straw it seems is the cra_bench failure, can you assist?

@shilman shilman merged commit 16b1014 into next May 10, 2022
@shilman shilman deleted the tech/upgrade-telejson-6 branch May 10, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants