API: Deprecate isToolshown, rename to showToolbar #18131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit aad962b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
approved these changes
May 4, 2022
There was a problem hiding this comment.
Thanks so much @JonathanKolnik !! 🙏
@ndelangen can you please review & make sure that isToolshown is still supported until 7.0?
shilman
changed the title
|
@JonathanKolnik looks like there are CI failures |
JonathanKolnik
force-pushed
the
jono/sb-334-deprecate-istoolshown-storybook
branch
from
1422323 to
b514ef0
Compare
|
@JonathanKolnik FYI I updated this PR with proper deprecation instructions. Please check it out! |
|
@shilman thank you, I actually meant to ask you about this after seeing a similar message on Friday but got sidetracked! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This is a follow up to #18106 where @shilman mentioned that we should rename isToolshown to showToolbar and deprecate isToolshown.
What I did
Renamed isToolshown to showToolbar in most of the code and docs and deprecate isToolshown, left it as an optional config which I believe is the correct way to deprecate this specific config.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.