Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Add safecheck for crash reports #18129

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 3, 2022

Issue:

What I did

I added an optional chaining opetator to a check in telemetry

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the bug label May 3, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bee8b14. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Telemetry: add safecheck for crash reports Telemetry: Add safecheck for crash reports May 4, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 45e37e4 into next May 4, 2022
@shilman shilman deleted the fix/telemetry-check branch May 4, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants