Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build chain upgrades: TS4, Webpack5, modern ESM, TSUP, (5b/N) #18034

Closed
wants to merge 51 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 23, 2022

Issue: N/A

What I did

Builds on #18024

  • Upgrade to TS4
  • Upgrade monorepo to Webpack5, removed Webpack4 temporarily
  • Upgrade ESM settings to modern
  • Upgrade CRA examples to CRA5 (for webpack5)

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Apr 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f5e87c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added the maintenance User-facing maintenance tasks label Apr 23, 2022
@shilman shilman force-pushed the future/modern-esm branch from fb2e1f3 to 9dab2de Compare April 23, 2022 05:01
@shilman shilman mentioned this pull request Apr 23, 2022
1 task
@ndelangen ndelangen self-assigned this Apr 25, 2022
# Conflicts:
#	addons/a11y/package.json
#	addons/actions/package.json
#	addons/backgrounds/package.json
#	addons/controls/package.json
#	addons/docs/package.json
#	addons/essentials/package.json
#	addons/interactions/package.json
#	addons/jest/package.json
#	addons/links/package.json
#	addons/measure/package.json
#	addons/outline/package.json
#	addons/storyshots/storyshots-core/package.json
#	addons/storysource/package.json
#	addons/toolbars/package.json
#	addons/viewport/package.json
#	app/ember/package.json
#	app/html/package.json
#	app/preact/package.json
#	app/react/package.json
#	app/server/package.json
#	app/svelte/package.json
#	app/vue/package.json
#	app/vue3/package.json
#	app/web-components/package.json
#	examples/cra-kitchen-sink/package.json
#	examples/cra-react15/package.json
#	examples/cra-ts-essentials/package.json
#	examples/cra-ts-kitchen-sink/package.json
#	examples/ember-cli/package.json
#	examples/official-storybook/package.json
#	lib/addons/package.json
#	lib/api/package.json
#	lib/builder-webpack4/package.json
#	lib/builder-webpack5/package.json
#	lib/channel-postmessage/package.json
#	lib/channel-websocket/package.json
#	lib/channels/package.json
#	lib/cli/src/versions.ts
#	lib/client-api/package.json
#	lib/client-logger/package.json
#	lib/codemod/package.json
#	lib/components/package.json
#	lib/core-client/package.json
#	lib/core-common/package.json
#	lib/core-events/package.json
#	lib/core-server/package.json
#	lib/csf-tools/package.json
#	lib/docs-tools/package.json
#	lib/instrumenter/package.json
#	lib/manager-webpack4/package.json
#	lib/manager-webpack5/package.json
#	lib/node-logger/package.json
#	lib/postinstall/package.json
#	lib/preview-web/package.json
#	lib/router/package.json
#	lib/source-loader/package.json
#	lib/store/package.json
#	lib/theming/package.json
#	lib/ui/package.json
#	presets/react-webpack/package.json
#	yarn.lock
@shilman shilman changed the title Build chain upgrades: TS4, Webpack5, modern ESM Build chain upgrades: TS4, Webpack5, modern ESM (5b/N) May 8, 2022
ndelangen added 6 commits May 9, 2022 19:43
# Conflicts:
#	addons/a11y/package.json
#	addons/actions/package.json
#	addons/backgrounds/package.json
#	addons/controls/package.json
#	addons/docs/package.json
#	addons/essentials/package.json
#	addons/interactions/package.json
#	addons/jest/package.json
#	addons/links/package.json
#	addons/measure/package.json
#	addons/outline/package.json
#	addons/storyshots/storyshots-core/package.json
#	addons/storysource/package.json
#	addons/toolbars/package.json
#	addons/viewport/package.json
#	app/ember/package.json
#	app/html/package.json
#	app/preact/package.json
#	app/react/package.json
#	app/server/package.json
#	app/svelte/package.json
#	app/vue/package.json
#	app/vue3/package.json
#	app/web-components/package.json
#	examples/angular-cli/.storybook/main.js
#	examples/cra-kitchen-sink/.storybook/main.js
#	examples/cra-kitchen-sink/package.json
#	examples/cra-react15/.storybook/main.js
#	examples/cra-react15/package.json
#	examples/cra-ts-essentials/.storybook/main.ts
#	examples/cra-ts-essentials/package.json
#	examples/cra-ts-kitchen-sink/.storybook/main.ts
#	examples/cra-ts-kitchen-sink/package.json
#	examples/ember-cli/.storybook/main.js
#	examples/ember-cli/package.json
#	examples/external-docs/package.json
#	examples/html-kitchen-sink/.storybook/main.js
#	examples/official-storybook/main.ts
#	examples/official-storybook/package.json
#	examples/preact-kitchen-sink/.storybook/main.js
#	examples/react-ts/package.json
#	examples/svelte-kitchen-sink/.storybook/main.js
#	examples/vue-3-cli/.storybook/main.js
#	examples/vue-3-cli/package.json
#	examples/vue-cli/.storybook/main.js
#	examples/vue-cli/package.json
#	examples/vue-kitchen-sink/.storybook/main.js
#	examples/web-components-kitchen-sink/.storybook/main.js
#	lib/addons/package.json
#	lib/api/package.json
#	lib/builder-webpack4/package.json
#	lib/builder-webpack5/package.json
#	lib/channel-postmessage/package.json
#	lib/channel-websocket/package.json
#	lib/channels/package.json
#	lib/cli/src/versions.ts
#	lib/client-api/package.json
#	lib/client-logger/package.json
#	lib/codemod/package.json
#	lib/components/package.json
#	lib/core-client/package.json
#	lib/core-common/package.json
#	lib/core-events/package.json
#	lib/core-server/package.json
#	lib/core-server/src/build-static.ts
#	lib/core-server/src/core-presets.test.ts
#	lib/core-server/src/utils/get-preview-builder.ts
#	lib/csf-tools/package.json
#	lib/docs-tools/package.json
#	lib/instrumenter/package.json
#	lib/manager-webpack4/package.json
#	lib/manager-webpack5/package.json
#	lib/node-logger/package.json
#	lib/postinstall/package.json
#	lib/preview-web/package.json
#	lib/router/package.json
#	lib/source-loader/package.json
#	lib/store/package.json
#	lib/theming/package.json
#	lib/ui/package.json
#	presets/react-webpack/package.json
#	scripts/build-manager-config/main.js
#	scripts/build-manager.js
#	yarn.lock
# Conflicts:
#	addons/links/package.json
#	lib/components/package.json
#	lib/ui/package.json
#	yarn.lock
Base automatically changed from future/minimize-webpack-deps to future/add-frameworks May 11, 2022 12:07
@ndelangen ndelangen changed the title Build chain upgrades: TS4, Webpack5, modern ESM (5b/N) Build chain upgrades: TS4, Webpack5, modern ESM, TSUP, (5b/N) May 12, 2022
@shilman
Copy link
Member Author

shilman commented May 21, 2022

Closing in favor of #18205

@shilman shilman closed this May 21, 2022
@stof stof deleted the future/modern-esm branch August 31, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants