fix(#16232): use a11y params > element properly #17989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06eeb2f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kylegach
reviewed
Apr 26, 2022
kylegach
reviewed
Apr 26, 2022
There was a problem hiding this comment.
Thanks for this, @jsomsanith! I left a comment that's worth discussing, but it generally looks good!
Co-authored-by: Kyle Gach <[email protected]>
|
@kylegach thanks for the review |
kylegach
reviewed
Apr 26, 2022
Co-authored-by: Kyle Gach <[email protected]>
- Updates story's parameters to match changes in previous commit (9feb188) - Minor wording/style changes
kylegach
approved these changes
May 3, 2022
There was a problem hiding this comment.
Thanks for this improvement, @jsomsanith! 👏
I pushed a commit with a fix and some minor wording/style updates. I'll merge as soon as CI does its thing.
|
I don't think the CI failures are related to this PR, so I'm going to merge. |
|
Thank for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16232
What I did
The a11y param > element was not used properly. It is supposed to be an element id too serve as scan root, but the code takes it as the element itself.
Furthermore, if no element is passed in params, it queries a
#story-rootelement first that comes from nowhere (no ref found in the repo) before taking#root.I removed this unknown
#story-rootand take theelementparam properly as element id.How to test
If your answer is yes to any of these, please make sure to include it in your PR.
Added a story about a11 parameters in official-storybook example