feat(#16235): display a11y issues number in addon tab title #17983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1c33d26. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
jsomsanith
force-pushed
the
jsomsanith/16235/a11y_tab_nb
branch
from
50e2a80 to
3d4ee80
Compare
jsomsanith
force-pushed
the
jsomsanith/16235/a11y_tab_nb
branch
from
3d4ee80 to
147271d
Compare
kylegach
approved these changes
May 3, 2022
There was a problem hiding this comment.
Works a treat, and code looks good! Thank you, @jsomsanith! 🙏 This a nice little tweak, and I appreciate that you properly tested it.
|
Thank you for the review @kylegach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16235
What I did
Display the number of a11y issues in the addon tab title.
Addon-a11ycontext doesn't store the axe result in a react state anymore, but in the store exposed byapi.The title in
addon-a11yis now a function that gets the addon result from api addon state, and build the title accordingly.impacted tests have been adapted, and tests on
addon-a11ymanager have been added.How to test
If your answer is yes to any of these, please make sure to include it in your PR.