Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Avoid framework imports from core/client #17875

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Core: Avoid framework imports from core/client #17875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e957ea2
Avoid forcing CJS import from core/client
IanVS Apr 4, 2022
2d5b3a3
Add comment about reason for file
IanVS Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/angular/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable prefer-destructuring */
import type { ClientStoryApi, Loadable } from '@storybook/addons';
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import './globals';
import { renderToDOM, render } from './render';
import decorateStory from './decorateStory';
Expand Down
2 changes: 1 addition & 1 deletion app/ember/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';

import './globals';
import { renderToDOM } from './render';
Expand Down
2 changes: 1 addition & 1 deletion app/html/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable prefer-destructuring */
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';
import { HtmlFramework } from './types-6-0';

Expand Down
2 changes: 1 addition & 1 deletion app/preact/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable prefer-destructuring */
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/react/src/client/preview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable prefer-destructuring */
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/server/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/svelte/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import { decorateStory } from './decorators';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/vue/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable prefer-destructuring */
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/vue3/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { App } from 'vue';
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion app/web-components/src/client/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable prefer-destructuring */
import { start } from '@storybook/core/client';
import { start } from '@storybook/core';
import type { ClientStoryApi, Loadable } from '@storybook/addons';

import './globals';
Expand Down
2 changes: 1 addition & 1 deletion docs/snippets/common/storybook-client-preview.ts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```ts
// your-framework/src/client/preview/index.ts

import { start } from '@storybook/core/client';
import { start } from '@storybook/core';

import './globals';

Expand Down
2 changes: 2 additions & 0 deletions lib/core/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
// @storybook/core was split into core-client and core-server. This file is for backwards-compat.
// TODO: remove in 7.0
module.exports = require('./dist/esm/index');