Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-interactions: Use 'global' package instead of global #17614

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Mar 2, 2022

Issue: #17516

What I did

I totally flubbed #17535, by using global instead of what I meant to use, globalThis. But, then I looked in the storybook codebase, and globalThis is not used anywhere else, and eslint doesn't like it, so this PR is going back to the initial way I opened that PR, using the global package, which storybook does use in multiple spots to handle globals across node and browsers.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit adbb6a2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested your previous PR and it was working correctly (although I didn't test in vite), but this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants