-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: MDX2 support #17515
Addon-docs: MDX2 support #17515
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 4db254e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
d44218a
to
56e24a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a PR for the two packages we should be looking at?
So this means that all apps will depend on @storybook/mdx1-csf
and folks that opt in will depend on both? Is that going to be OK from a dependencies point of view?
remarkPlugins: [remarkSlug, remarkExternalLinks], | ||
}; | ||
|
||
const mdxVersion = global.FEATURES?.previewMdx2 ? 'MDX2' : 'MDX1'; | ||
log(`Addon-docs: using ${mdxVersion}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Console log is intentional?
@tmeasday Yes, there are two more PRs here The dependency structure is as you described. I don't anticipate any dependency conflicts inside Storybook because each package depends on a specific version and Storybook only depends on the packages. It could, however, cause conflicts with the user's app. This is why we've been prebundling dependencies, and I supppose we could consider prebundling these packages as well. This would require @ndelangen to generalize his prebundling script to be used outside the SB monorepo, and I don't think we need to do it right away. There is one "hack" which is that SB depends on
|
@shilman - wondering if this is documented somewhere around how to use the experimental config w/ mdx2 in storybook 6.5 by chance?? (I'm in a large mono repo that across the board moved to mdx2 and really cannot yet move to storybook 7, so hopeful to get this to run/kick some tires on it! Much appreciate in advance for any help/guidance on it) |
Think I may have just found it...is this the correct "guide": https://gist.github.com/shilman/6ff2d7e18db8846e8fc552fb432ae4f6 ?? |
Issue: #17514 #17137
What I did
How to test