Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Ensure we show an error when configure() throws #17435

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 7, 2022

Issue: When user's configure() threw, we didn't show an error:

image

What I did

Ensure we handle the (old) CONFIG_ERROR event in the manager to show the underlying iframe.

image

How to test

  • Is this testable with Jest or Chromatic screenshots?

Yes, see test.

@nx-cloud
Copy link

nx-cloud bot commented Feb 7, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 6d90c11. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Feb 7, 2022
@shilman shilman changed the title Ensure we show an error when configure() throws Core: Ensure we show an error when configure() throws Feb 7, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--pretty simple in the end!

@shilman shilman merged commit 70a3ef7 into next Feb 7, 2022
@shilman shilman deleted the fix-configure-error-handling branch February 7, 2022 08:00
@tmeasday
Copy link
Member Author

tmeasday commented Feb 8, 2022

Oh, this was just a small bug I found, not the full fix for the problem @shilman

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 12, 2022
shilman added a commit that referenced this pull request Feb 12, 2022
Core: Ensure we show an error when `configure()` throws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants