Chore: (Docs) Updates Storybook configuration docs for TS and flags. #17358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
added
documentation
patch:yes
☁️ Nx Cloud ReportCI ran the following commands for commit 5fe5b45. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
requested changes
Feb 7, 2022
| import type { StorybookConfig } from '@storybook/core-common'; | ||
|
|
||
| const BaseConfig: StorybookConfig = { | ||
| stories: [], |
There was a problem hiding this comment.
Can we make this into a realistic file? In the current form it doesn't seem to be very useful. Also baseConfig since it's a variable?
There was a problem hiding this comment.
Indeed we can, and I've updated it with the latest commit. Let me know if you're ok with it, or any other feedback. Thanks for taking the time to review it @shilman !
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Feb 12, 2022
…onfig_overview Chore: (Docs) Updates Storybook configuration docs for TS and flags.
|
Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, the documentation is updated to include TS support and available feature flags.
What was done:
Closes #16079 and #15629
@shilman would appreciate some feedback on this, and please let me know if I forgot any feature flags or something of that nature. Thanks in advance.