Core: Fix negated glob support #17328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary: Support negated globs like `../!(negation)/*.stories.mdx` in storybook config. **Related issues:** Closes storybookjs#16964
☁️ Nx Cloud ReportCI ran the following commands for commit 5d476f0. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
approved these changes
Jan 25, 2022
|
One ci run failed. Is this expected? Do I need to do anything? |
tmeasday
added
bug
core
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jan 28, 2022
Core: Fix negated glob support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16964
Summary:
Support negated globs like
../!(negation)/*.stories.mdxin storybookconfig.
Related issues:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.