UI: Prebundle @storybook/components

[ndelangen]

This uses #17000 to prebundle lib/components

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 8dcd346. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[ndelangen]

hmmm..

export 'mdx' was not found in '@mdx-js/react'

[ndelangen]

@shilman any idea on the above?

[shilman]

@ndelangen looks like it's referenced here:

https://github.com/storybookjs/storybook/blob/next/addons/docs/jest-transform-mdx.js#L15

And looks like it's defined in the package:

exports.mdx = createElement;

So I'm not sure why it's failing 🤷‍♂️

[shilman]

@ndelangen aha here's why it's failing: https://github.com/mdx-js/mdx/releases/tag/2.0.0

something is installing 2.0 which was released 2h ago, and we're compatible with 1.x only.

[ndelangen]

but we specify we need 1.x:

storybook/addons/docs/package.json

Line 66 in 430672e

"@mdx-js/react": "^1.6.22",

[ndelangen]

ahh maybe this is is?

storybook/lib/cli/src/generators/baseGenerator.ts

Lines 89 to 90 in ee1e8ec

	const yarn2Dependencies =
	packageManager.type === 'yarn2' ? ['@storybook/addon-docs', '@mdx-js/react'] : [];

I think @mdx-js/react should be removed here. Or set to 1.x version

[ndelangen]

getting the same problem here:
#17375

[ndelangen]

@shilman This might be a pretty big deal!!

[ndelangen]

I had to add @types/react to angular to get it to compile... @gaetanmaisse WDYT about this?

[ndelangen]

Hmm, so that didn't work?

ERR! => Failed to build the preview
ERR! node_modules/@storybook/router/dist/ts3.9/_modules/react-router-dom-index.d.ts:57:20 - error TS2694: Namespace 'React' has no exported member 'HTMLAttributeAnchorTarget'.
ERR! 
ERR! 57     target?: React.HTMLAttributeAnchorTarget;
ERR!                       ~~~~~~~~~~~~~~~~~~~~~~~~~
ERR!

[ndelangen]

If I added @types/react to the packages (router, theming) wouldn't that potentially cause issues for Vue?

[shilman]

Great job @ndelangen 🎖️