Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI generators export #1722

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fix CLI generators export #1722

merged 1 commit into from
Aug 23, 2017

Conversation

PierrickP
Copy link
Contributor

What I did

Fix this PR #1652
Correctly export VUE and WEBPACK_REACT generators

How to test

Use cli on vue / webpack_react projects

Correctly export `VUE` and `WEBPACK_REACT` generators
@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #1722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1722   +/-   ##
=======================================
  Coverage   21.18%   21.18%           
=======================================
  Files         252      252           
  Lines        5694     5694           
  Branches      681      676    -5     
=======================================
  Hits         1206     1206           
- Misses       3961     3973   +12     
+ Partials      527      515   -12
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-32.15%) ⬇️
addons/info/src/components/Node.js 38.88% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9d905...fded787. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Thanks!

@Hypnosphi Hypnosphi merged commit 658e359 into storybookjs:master Aug 23, 2017
@shilman shilman changed the title Fix generators export Fix CLI generators export Aug 23, 2017
@shilman
Copy link
Member

shilman commented Aug 23, 2017

@Hypnosphi @PierrickP can either of you explain why this is needed? I'm fine with the change, but I actually don't understand what's going on here. Thanks! 😬

@Hypnosphi
Copy link
Member

I accidentally removed module export = in those two generators. I should have tested all the generators, but did it only for a few of them. Maybe we need an e2e test for CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants