Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update [email protected] & [email protected] same as cra5 #17056

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

phnessu4
Copy link
Contributor

@phnessu4 phnessu4 commented Dec 22, 2021

Issue: #17049

update [email protected] & [email protected] same as cra5

What I did

just update the package version

How to test

reinstall the new package with the error environment

  • [N] Is this testable with Jest or Chromatic screenshots?
  • [N] Does this need a new example in the kitchen sink apps?
  • [N] Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 22, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit f133abe. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added react cra Prioritize create-react-app compatibility dependencies labels Dec 23, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @phnessu4 🙏

@shilman shilman merged commit a39f465 into storybookjs:next Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cra Prioritize create-react-app compatibility dependencies react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants