Angular: Fix tsConfig paths not resolving for Angular >=12.2 #16882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit f384c0e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit f384c0e. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Dec 3, 2021
Angular: Fix tsConfig paths not resolving for Angular >=12.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16759
What I did
Added
TsconfigPathsPluginto Angualr >=12.2 Webpack configs.While trying to make sure the tests, other than windows paths not matching, I ran into a windows specific error that happens when passing
undefinedtogetSystemPath. The tests were failing from the testangular.jsonconfigs not defining "sourceRoot".https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/core/src/virtual-fs/path.ts#L293
How to test
The tests can probably be improved for detecting this, but I wanted to get the PR submitted tonight.
If your answer is yes to any of these, please make sure to include it in your PR.