Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix build-storybook sort bug in v6-mode #16724

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 19, 2021

Issue: #16638

What I did

  • Improve error message for bad sort function in v6
  • Skip sorting altogether when we're generating stories.json in v6-mode

How to test

See examples/react-ts which has a few different sort functions in preview.js

Can add a unit test if you twist my arm

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2021

Nx Cloud Report

CI ran the following commands for commit 43f9f14. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 43f9f14.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@shilman shilman requested a review from tmeasday November 19, 2021 04:05
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit cf4b3c7 into next Nov 19, 2021
@shilman shilman deleted the 16638-fix-build-storybook-sort branch November 19, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants