Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix detection of @angular/cli package version #16696

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

juristr
Copy link
Contributor

@juristr juristr commented Nov 16, 2021

Issue:

Right now in 6.4.0 rc.2 there is an issue with the detection of the @angular/cli package version. The current setup reads the package.json for the presence of the @angular/cli. That doesn't work in the case of a publishable Angular library, which has it's own package.json but does not contain a reference to the @angular/cli package (like an Angular application).

This PR fixes it, by resolving the @angular/cli package and by reading its exported VERSION constant.

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Nov 16, 2021

Nx Cloud Report

CI ran the following commands for commit e747ee5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@juristr juristr force-pushed the fix-angular-cli-version-detection branch from 3852dd0 to acb2a1c Compare November 16, 2021 13:23
@juristr juristr marked this pull request as ready for review November 16, 2021 13:24
@shilman shilman changed the title fix detection of @angular/cli package version Angular: Fix detection of @angular/cli package version Nov 16, 2021
@shilman shilman added this to the 6.4 PRs milestone Nov 16, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💯 Thanks @juristr !!!

@shilman shilman merged commit 1744863 into storybookjs:next Nov 16, 2021
@ThibaudAV
Copy link
Contributor

LGTM 🚀 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants