Angular: Fix detection of @angular/cli package version #16696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Right now in
6.4.0 rc.2
there is an issue with the detection of the@angular/cli
package version. The current setup reads the package.json for the presence of the@angular/cli
. That doesn't work in the case of a publishable Angular library, which has it's ownpackage.json
but does not contain a reference to the@angular/cli
package (like an Angular application).This PR fixes it, by resolving the
@angular/cli
package and by reading its exportedVERSION
constant.What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.