Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Run automigrate at the end of sb init #16671

Merged
merged 4 commits into from
Nov 12, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 12, 2021

Issue: #16439

What I did

As title says

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation? Maybe?

1 - Generate a sample project without storybook
2 - yarn build cli
3 - <path-to>/storybook/lib/cli/bin/index.js init

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Nov 12, 2021

Nx Cloud Report

CI ran the following commands for commit b177b3e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

lib/cli/src/initiate.ts Outdated Show resolved Hide resolved
@shilman shilman changed the title CLI: Run automigrate automatically at the end of sb init CLI: Run automigrate at the end of sb init Nov 12, 2021
@shilman shilman added this to the 6.4 PRs milestone Nov 12, 2021
@yannbf yannbf requested a review from shilman November 12, 2021 11:30
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yannbf !!! 🙏

@shilman shilman merged commit 6dec28a into next Nov 12, 2021
@shilman shilman deleted the feat/include-automigrate-in-sb-init branch November 12, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants