Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not ship @types/react when production to avoid type conflicts #16630

Closed
wants to merge 2 commits into from

Conversation

upupming
Copy link

@upupming upupming commented Nov 8, 2021

Issue: do not ship @types/react when production, see #16629 (comment)

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Nov 8, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit bba91d3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@upupming upupming mentioned this pull request Nov 8, 2021
3 tasks
@upupming upupming changed the title Update package.json do not ship @types/react when production to avoid type conflicts Nov 8, 2021
@shilman
Copy link
Member

shilman commented Nov 8, 2021

More discussion here vuejs/core#1033

XavierChevalier pushed a commit to XavierChevalier/jam that referenced this pull request Nov 26, 2021
Refs: //github.com/storybookjs/storybook/pull/16629,//github.com/storybookjs/storybook/pull/16630,//github.com/vuejs/core/issues/1033,//github.com/storybookjs/storybook/issues/12505,//github.com/XavierChevalier/ewokify-app/runs/4326759026?check_suite_focus=true
@ndelangen
Copy link
Member

We are working towards this goal in 7.0 in the future/base branch.

There's really not much we can do in 6.5 because removing the types make it unsound, and will break another set of users, unfortunately.

@upupming Thank you for the PR and helping work out what needs to happen.
As mentioned this will all be addressed and fixed in 7.0.

I'm sorry, but I have to close this PR, because to actually address this we can't simply move some items independencies to devDependencies, instead we need to change a lot of architecture (which is happening in the future/base branch!

@ndelangen ndelangen closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants