-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix CI checks #16535
Build: Fix CI checks #16535
Conversation
Nx Cloud ReportCI ran the following commands for commit 0ca55ae. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Still to discuss (@yannbf @shilman I will ping you on Discord):
|
I'll check this as soon as I can! My feeling is that @tmeasday knows what could be causing this. I think that message has been introduced recently |
Wow, it was a while ago I added that warning and I can't quite remember, but I am sure it would have been something we discussed @shilman? Perhaps you recall. In any case, I guess the warning is sort of self explanatory. Is this an issue with the backgrounds addon? |
I'll look into the HTML snippet issue |
HTML code snippet is ok now ✅ There is still an issue with addon background + vue, see CircleCI artefact: https://351763-54173593-gh.circle-artifacts.com/3/cypress/sfcVue/addon-backgrounds.spec.ts.mp4 @shilman I can try to investigate a bit more on ⬆️ during the next few days but I think it worth it to merge this PR as it fixes a lot of other CI issues |
What I did
eslint
ignore comment to disable ano-underscore-dangle
error inlib/components/src/bar/button.stories.tsx
(introduced by UI: Update the toolbar button styles #16429)How to test