Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix CI checks #16535

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Build: Fix CI checks #16535

merged 5 commits into from
Nov 12, 2021

Conversation

gaetanmaisse
Copy link
Member

What I did

  • Add eslint ignore comment to disable a no-underscore-dangle error in lib/components/src/bar/button.stories.tsx (introduced by UI: Update the toolbar button styles #16429)
  • Update Preact preset filename
  • Skip source snippet cypress test for @storybook/html

How to test

  • CI should be 🟢

@nx-cloud
Copy link

nx-cloud bot commented Oct 31, 2021

Nx Cloud Report

CI ran the following commands for commit 0ca55ae. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows labels Oct 31, 2021
@gaetanmaisse
Copy link
Member Author

Still to discuss (@yannbf @shilman I will ping you on Discord):

  • Background change isn't working every time with Vue (but after multiple selections it finally works) -> Locally I have the following warning in console: Setting a global value that is undeclared (i.e. not in the user's initial set of globals or globalTypes) is deprecated and will have no effect in 7.0. so maybe we have to update the CLI templates?
  • addon-docs cypress tests for Preact -> are the feature implemented but not working or should we disable the tests?

@yannbf
Copy link
Member

yannbf commented Nov 1, 2021

Still to discuss (@yannbf @shilman I will ping you on Discord):

  • Background change isn't working every time with Vue (but after multiple selections it finally works) -> Locally I have the following warning in console: Setting a global value that is undeclared (i.e. not in the user's initial set of globals or globalTypes) is deprecated and will have no effect in 7.0. so maybe we have to update the CLI templates?
  • addon-docs cypress tests for Preact -> are the feature implemented but not working or should we disable the tests?

I'll check this as soon as I can! My feeling is that @tmeasday knows what could be causing this. I think that message has been introduced recently

@tmeasday
Copy link
Member

tmeasday commented Nov 1, 2021

Wow, it was a while ago I added that warning and I can't quite remember, but I am sure it would have been something we discussed @shilman? Perhaps you recall.

In any case, I guess the warning is sort of self explanatory. Is this an issue with the backgrounds addon?

@shilman shilman self-assigned this Nov 1, 2021
@shilman
Copy link
Member

shilman commented Nov 1, 2021

I'll look into the HTML snippet issue

@gaetanmaisse
Copy link
Member Author

HTML code snippet is ok now ✅

There is still an issue with addon background + vue, see CircleCI artefact: https://351763-54173593-gh.circle-artifacts.com/3/cypress/sfcVue/addon-backgrounds.spec.ts.mp4

@shilman I can try to investigate a bit more on ⬆️ during the next few days but I think it worth it to merge this PR as it fixes a lot of other CI issues

@gaetanmaisse gaetanmaisse marked this pull request as ready for review November 11, 2021 20:13
@shilman shilman added this to the 6.4 PRs milestone Nov 12, 2021
@shilman shilman merged commit 26f6707 into next Nov 12, 2021
@shilman shilman deleted the fix-ci-6.4.beta23 branch November 12, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants