-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs/Angular: fix extractEnumValues undefined error #16524
Addon-docs/Angular: fix extractEnumValues undefined error #16524
Conversation
…ulting in crash" This reverts commit 11af03f.
…ndefined-error Revert "[BUGFIX]: prevent app crash when no typealias found"
…resulting in crash
Nx Cloud ReportCI ran the following commands for commit 0a2dbfe. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Hi everybody, Do I have to do something here? Seems CI is broken, however, I just changed one line Kind regards |
@KMathyTech yeah, we have some unrelated CI issues. I plan to review soon but am hustling to try to get 6.4 out the door and it's taking all my waking hours (and even some non-waking ones)! Thanks for your patience and for the contribution 🙏 |
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience
What I did
This is the same problem as #16523. I took a look to the entire file, and now, that should work as expected with the result 'object' when resolving types 😄 If you want to avoid this kind of problem, I recommend to enable strict mode in your tsconfig file. However, the entire project is really big and it could be a huge refactoring in some places... 🤔
How to test
If your answer is yes to any of these, please make sure to include it in your PR.