Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs/Angular: fix extractEnumValues undefined error #16524

Merged
merged 6 commits into from
Nov 17, 2021
Merged

Addon-docs/Angular: fix extractEnumValues undefined error #16524

merged 6 commits into from
Nov 17, 2021

Conversation

Nxtivision
Copy link
Contributor

What I did

This is the same problem as #16523. I took a look to the entire file, and now, that should work as expected with the result 'object' when resolving types 😄 If you want to avoid this kind of problem, I recommend to enable strict mode in your tsconfig file. However, the entire project is really big and it could be a huge refactoring in some places... 🤔

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2021

Nx Cloud Report

CI ran the following commands for commit 0a2dbfe. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@Nxtivision
Copy link
Contributor Author

Hi everybody,

Do I have to do something here? Seems CI is broken, however, I just changed one line

Kind regards

@shilman
Copy link
Member

shilman commented Nov 10, 2021

@KMathyTech yeah, we have some unrelated CI issues. I plan to review soon but am hustling to try to get 6.4 out the door and it's taking all my waking hours (and even some non-waking ones)! Thanks for your patience and for the contribution 🙏

@Nxtivision
Copy link
Contributor Author

@KMathyTech yeah, we have some unrelated CI issues. I plan to review soon but am hustling to try to get 6.4 out the door and it's taking all my waking hours (and even some non-waking ones)! Thanks for your patience and for the contribution 🙏

Hey,
no worries, I understand the importance of the project and the time you devote to it. Take the time you need 😄

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your patience

@shilman shilman added this to the 6.4 PRs milestone Nov 17, 2021
@shilman shilman merged commit 36c1e6a into storybookjs:next Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants