-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for React presence when detecting WEBPACK_REACT
type
#1646
Conversation
(packageJson.dependencies && packageJson.dependencies.webpack)) && | ||
((packageJson.devDependencies && packageJson.devDependencies.react) || | ||
(packageJson.dependencies && packageJson.dependencies.react)) | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably extract those checks into a function
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 20.87% 20.87%
=======================================
Files 251 251
Lines 5629 5629
Branches 675 690 +15
=======================================
Hits 1175 1175
+ Misses 3952 3926 -26
- Partials 502 528 +26
Continue to review full report at Codecov.
|
Merge when ready |
To prevent incorrect detection when a vue project has webpack installed