Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix paths to be relative to working dir in v7 mode #16328

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 13, 2021

What I did

Fix the entry point paths so importing is relative to the working dir (which how importPaths are specified).

This wasn't breaking in react-ts due to it's unusual main.js location :hurtrealbad: @shilman do you have a PR to change this? I could add it to this PR.

How to test

Check react-ts

@nx-cloud
Copy link

nx-cloud bot commented Oct 13, 2021

Nx Cloud Report

CI ran the following commands for commit 6febea3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@tmeasday tmeasday added the bug label Oct 13, 2021
@tmeasday tmeasday requested a review from shilman October 13, 2021 01:07
@shilman shilman changed the title Paths need to be relative to working dir in v7 mode too Core: Fix paths to be relative to working dir in v7 mode Oct 13, 2021
@shilman shilman added the core label Oct 13, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fun never stops, does it? 😂

@shilman shilman merged commit 9a506dd into next Oct 13, 2021
@shilman shilman deleted the fix-stories-entry-path branch October 13, 2021 03:02
@shilman shilman added this to the 6.4 PRs milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants