Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add Story Index error handling #16319

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Core: Add Story Index error handling #16319

merged 4 commits into from
Oct 13, 2021

Conversation

tmeasday
Copy link
Member

Issue: #15816

Telescoping on #16242

What I did

  • Catch 500 errors from stories.json and show in a redbox in the preview (like other errors from preview.js)
  • Set the store to be "errored" in the manager, which has the effect of showing a loading state in the sidebar

How to test

  • Is this testable with Jest or Chromatic screenshots?

Screenshot

image

@tmeasday tmeasday requested a review from shilman October 12, 2021 12:39
@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 6699ba7. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title Story Index Error Behaviour Core: Add Story Index error handling Oct 12, 2021
shilman
shilman approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😻

shilman
shilman requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But lots of unit tests failing. Fixed a few but ran out of steam.

@tmeasday
Copy link
Member Author

tmeasday commented Oct 12, 2021 •
edited
Loading

Thanks @shilman, I can fix them

@shilman shilman merged commit 866ec9f into 16222-sort-function-errors Oct 13, 2021
@shilman shilman deleted the 15816-story-index-error-behaviour branch October 13, 2021 01:06
@shilman shilman mentioned this pull request Oct 13, 2021
Closed
2 tasks
@shilman shilman added this to the 6.4 PRs milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
core feature request ui
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman