Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix dotenv handling #16105

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Core: Fix dotenv handling #16105

merged 3 commits into from
Sep 21, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 19, 2021 •
edited
Loading

Issue: #16067

What I did

  • Removed dotenv-webpack
  • Define process.env to support destructuring

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Sep 19, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit c418258. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman marked this pull request as ready for review September 20, 2021 11:54
tmeasday
tmeasday approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit f552d6c into next Sep 21, 2021
@shilman shilman deleted the 16067-fix-dotenv-resolution branch September 21, 2021 02:41
@shilman shilman mentioned this pull request Sep 21, 2021
Closed
@shilman shilman added this to the 6.4 PRs milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
bug configuration babel / webpack core
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday