Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix sb link to yarn3 repos #15989

Merged
merged 1 commit into from
Sep 7, 2021
Merged

CLI: Fix sb link to yarn3 repos #15989

merged 1 commit into from
Sep 7, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 7, 2021 •
edited
Loading

Issue: N/A

What I did

Relax constraints on sb link to include yarn3 repos

Self-merging @gaetanmaisse

How to test

lib/cli/bin/index.js repro ../storybook-repros/foo -t react
lib/cli/bin/index.js link ../storybook-repros

Before this change, it will fail. After, it will succeed.

@nx-cloud
Copy link

nx-cloud bot commented Sep 7, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 0065c80. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added this to the 6.4 PRs milestone Sep 7, 2021
@shilman shilman merged commit 8a56e94 into next Sep 7, 2021
@shilman shilman deleted the fix/repro-link-yarn3 branch September 7, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug cli
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman