-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: On demand store #15871
Merged
Merged
Core: On demand store #15871
Changes from all commits
Commits
Show all changes
296 commits
Select commit
Hold shift + click to select a range
ed4076a
Remove logging
tmeasday 0b0111d
Making progress through the tests
tmeasday dddb811
Merge branch 'on-demand-store' of github.com:storybookjs/storybook in…
shilman 58338c9
Fix undefined story parameters
shilman 77cc48b
Addon-docs: Fix description block
shilman 5c3063c
More WebPreview tests
tmeasday d738115
Finished docs=>story tests
tmeasday ad35de6
Completed changing story tests
tmeasday 48e729f
Wrote story change during rendering tests
tmeasday 1ae012d
Finished story=>docs tests
tmeasday 1cd91c8
Added some initial HMR tests
tmeasday 36ab761
Added couple of full stack tests
tmeasday 1d5391c
Split out integration test, added rudimentary docs one
tmeasday 969fbb6
Update validateOptions behaviour and add test
tmeasday 004d93f
Merge branch 'on-demand-store' of github.com:storybookjs/storybook in…
shilman a036c23
Retain a delta of arg changes on HMR
tmeasday 760e97c
Add a test that arg changes are retained as you browse around
tmeasday f04c9ca
Updated globals behaviour on HMR to mirror args
tmeasday 3aa4fc8
Ensure we don't keep "spurious" changes on implementation updates
tmeasday ce7411e
Remove tests that have been ported :+1:
tmeasday 26abe9a
Move tests around selection specifier + HMR over
tmeasday 54a4fd9
Fix linting / compilation problems
tmeasday 5fd3c6f
Repair modules/stories tests
tmeasday 11887b5
Fix WebPreview tests
tmeasday 73cd49b
Fix `enhanceArgTypes`
tmeasday 52acabb
Fix addArgsHelpers test
tmeasday c9b5453
Official-storybook: Remove template strings (temporary)
shilman 5b44c6b
Official-storybook: Remove design-system (temporary)
shilman 890623c
Move new files from `client-api` => `store`
tmeasday eb452c6
Official-storybook: Fix main.ts config for on-demand store
shilman aa6fce5
Moved stuff to webpreview package
tmeasday 5e31fd9
Semi fix/hack client-api/core-client types so they build
tmeasday 50215d2
Need SB Types
tmeasday 2f48a40
Updated all render function to get build working
tmeasday a543878
Fix up UrlStore + internal types
tmeasday a9e9a08
Fix up `inferControls`
tmeasday 4064148
Migrate a lot of types in the on-demand-store
tmeasday 18d3633
A lot of type changes, not quite building yet
tmeasday a1568c3
Types + tests working in store
tmeasday f083f03
Don't do autotitle any more, get it from stories list
tmeasday acb5088
Got addon-controls working
tmeasday 56ac92f
Sorted out inferArgTypes
tmeasday f500ee5
Cleanup
tmeasday 2309e3d
Emit event on config error
tmeasday e2606f1
Implemented `ClientApi` shim
tmeasday 5b974e9
Got first version of storiesOf shim in. Not yet running
tmeasday 93d1669
Update CSF
tmeasday d05a6c1
Close to bootstrapping again
tmeasday a905b09
Got things bootstrappign
tmeasday 5772eb6
Got old-style working
tmeasday 7137e77
Some improvements
tmeasday 6dfe70c
Fixed some problems and added some tests for start.ts
tmeasday 7d3b6b8
Added a test for the combined case
tmeasday b2a7949
Added `forceReRender` to start
tmeasday 22db095
Clean code up a little
tmeasday 86847d9
Handle HMR in storiesOf
tmeasday 18a6e51
HMR tests for start
tmeasday dbf9e2f
Added a new feature `storyStoreV7`
tmeasday 5921d52
Maintain component order on HMR
tmeasday 1290b1e
Small cleanups
tmeasday ac043f9
We need to refetch the story list when the import fn changes
tmeasday 54d3cd0
Implemented .extract() and better getSetStoriesPayload() on store
tmeasday 0df595a
Small type fix
tmeasday ecf335e
Got getStorybook() going, refactor start + client-api
tmeasday 966a023
Somehow this got lost
tmeasday e88f66e
Fix type
tmeasday bee50c8
Add errors for removed APIs
tmeasday 3ee1537
Update decorators to use a common sanitization
tmeasday c3dfc33
Type finangling
tmeasday 82d2b57
Upgrade CSF again
tmeasday e1268c7
Clean up some exported APIs
tmeasday b9c8b87
Don't export `ConfigApi` any more -- not sure it could be used direct…
tmeasday 53ed7b4
Throw from client api exports if using storyStoreV7
tmeasday 2b4996c
Ensure SB globals are always defined
tmeasday 1d91c33
Re-established old addons types
tmeasday 10e6545
Re-add CSF types to addons
tmeasday a09a531
Fixed up ClientApi types
tmeasday 922e5ee
Update types in core-client
tmeasday 275155f
Got core-client going too
tmeasday 4621153
Cleanup
tmeasday ec5ddda
More cleanup
tmeasday 3279dbc
Update frameworks to use legacy types
tmeasday 23ee402
Update a bunch of types to get things to 'strap
tmeasday 8dfe9f9
Added a "sync" init path to allow storyshots to be sycn
tmeasday 7168f33
Don't watch a channel just yet in SLS
tmeasday 6f584a2
Fixed up getStorybook/raw and made storyshots work
tmeasday 6b4b753
Lock update
tmeasday 134d4ec
Reverse Story/UnboundStory
tmeasday 9cdd8f8
Update argTypes tests
tmeasday 7bfbe4c
Fix up angular decorators
tmeasday 990d53d
Pass component through angular properly (not on parameters any more)
tmeasday 4508487
Little improvement to `inferArgTypes`
tmeasday e4236c1
Repair globals/globalTypes in legacy
tmeasday b75ad58
Temporary work arounds for a couple of angular issues
tmeasday 6a7ddf3
Fix vue+svelte shots
tmeasday 92ef52f
Update snapshot (looks like this one was broken before)
tmeasday 2f50484
Update `yarn.lock`
tmeasday c062b8a
No need to mock in this test
tmeasday b8d5b1e
Move inferControls from the controls addon back into the store
tmeasday a886599
Move inferArgTypes back into the store
tmeasday dbffe93
Fix angular stories by moving component back into return value
tmeasday c14d5ef
Set legacy parameters in context for back-compat.
tmeasday 82d186b
Fix addon-docs tests
tmeasday 088ea76
Change `Framework` => `TFramework`
tmeasday 06fdc90
Whoops this was supposed to be optional
tmeasday b9048d5
Use breaking changes in store/preview tests
tmeasday f135983
Fix withActions
tmeasday ec9c4b8
Simplified iframe-webpack.config.js thanks to @ndelangen's feedback
tmeasday 7eaf944
Bring wp4 changes over to wp5
tmeasday 0277d2d
Remove incomplete tests for `to-importFn`
tmeasday d28587d
Add a note about backcompat
tmeasday c9e8fc3
Add template to wp5 builder
tmeasday 3e3d2c0
Add a test that `.extract()` filters docs-only
tmeasday 8abc869
Need to pick filenames carefully in configs
tmeasday 9c0a0c2
Added useStoryPrepared() hook
tmeasday 8ec4124
Fix global handling
tmeasday 7929292
Fix stories tests and added some for preparing
tmeasday 3b3d566
Fix ui mockdata
tmeasday 63e2536
Update `prepareStory` tests
tmeasday a154975
Simplify start tests by turning on breaking v7 changes
tmeasday e1b4d1a
Update vue snapshots with backcompat parameters
tmeasday d06b4a6
Ensure user's config is last on the list.
tmeasday c9b2db4
Updated `caniuse`
tmeasday afcd33d
Drop unused linting comments
tmeasday 37e7c8f
Add `StoryStore.getStoriesJsonData()`
tmeasday 1567164
Remove a lot of TODOs, clean up
tmeasday 263b005
Don't use title exports in non v7 store
tmeasday c6b1e5c
Didn't mean to commit this
tmeasday 9eb3afe
Drop a couple FIXMEs that were fixed
tmeasday 67f8827
Deal with multiple `storiesOf` in the same file
tmeasday f18d3b9
Ensure `render` is used in legacy mode
tmeasday d31cca3
Move sorting types back to addons
tmeasday 64724a2
Add sorting to back-compat store
tmeasday 816f331
Update extract to wait for init
tmeasday 4232e57
Undo extract change and fix up web-components-kitchen-sink
tmeasday cc4a16f
Fix incorrect link
tmeasday eeb3708
Update CSF version to pass Args through to stories
tmeasday 9006d0b
Don't put a `StoryFn` onto `render`
tmeasday d9bb26e
Various fixes
tmeasday c2ab7ea
Ensure we deal with cleaning up docs only too
tmeasday 74da384
Don't generate stories.json if we don't have to
tmeasday 013e12e
Re-add client-api to builder-webpack4
tmeasday f0ae133
Ensure the user (i.e. storyshots) fileName wins
tmeasday 5a75168
No idea why I need to update these angular snapshots
tmeasday 319b1bb
Add store to builder-webpackX deps
tmeasday 474b6c5
Add regenerator to store and web-preview
tmeasday 0f84323
Fix issue with args memory over HMR applying in the wrong place
tmeasday 90d6eac
Ensure we reset args *before* re-rendering
tmeasday a576375
Remove old comments
tmeasday d8349ef
Use object freeze to ensure stories are not editable
tmeasday 438e726
Switch `createGate` to a hooks-like syntax
tmeasday dcf018b
Ensure we handle it if loaders or play throw
tmeasday d2e713a
Fix old use of "Meta" (=> "Annotation")
tmeasday 1ad369c
Rename GlobalAnnotations => ProjectAnnotations
tmeasday 1fa95a0
Rename `WebPreview` to `PreviewWeb`
tmeasday 4e12e81
Rename `StoriesList` => `StoryIndex`
tmeasday 4c69483
Small fixes to get boostrapping
tmeasday e61c101
Split ClientApi facade into its own class
tmeasday 7d45c07
Add a "back-compat" API for `__STORYBOOK_CLIENT_API`
tmeasday 1f9e6ad
Cleanup
tmeasday 8d320c2
Deal with initial preview error
tmeasday 306029b
Add async-ness to Story+ArgsTable blocks
tmeasday c2236da
Update CSF version (projectAnnotations)
tmeasday 6432f6c
Fix bootstrap
tmeasday 5982475
Deepscan cleanups
tmeasday 4884f78
Update snapshots due to WP => PW change
tmeasday cb1c523
Remove unusued function arg (deepscan)
tmeasday c449713
Revert "fix(ArgControl): unbox the value to simplify the code"
gaetanmaisse 68b3ef6
Merge remote-tracking branch 'origin/next' into on-demand-store
tmeasday 8276397
Get it bootstrapping again
tmeasday c2bc484
Update CSF
tmeasday 674e26f
Tweak `ArgTypes`
tmeasday 4702cf0
Fix handlebars dep
tmeasday a504ad3
Improve types flushed out by CSF changes
tmeasday 08301a3
Fix a bunch of types
tmeasday f67d9e8
Remove autotitle story from angular
tmeasday 20bc63e
Fix broken `core-server` tests
tmeasday eb8ea01
Update two angular snapshots
tmeasday 26f83f5
Fix types in a couple of angular tests
tmeasday d83104c
Remove unused import
tmeasday b4b59df
Update csf dep in csf-tools
tmeasday 0536851
Switch order of args / argTypes enhancers
tmeasday b4a75b3
Add getter for `_storyStore` (back compat)
tmeasday 0bb2347
Fix mdx-in-story story
tmeasday e6698c5
Fix argtypes stories
tmeasday d2e837a
Fix ember
tmeasday c24a980
Remove autotitle story from angular SB / fix other
tmeasday ec23d8c
Ensure we run argTypes enhancers before pulling defaultValues
tmeasday 2325440
Wait a tick before apply arg changes and other re-renders.
tmeasday abbd38f
Fix globals
tmeasday 2ab56b2
Abort controller fallback for IE
tmeasday 956e131
Update CSF to allow `symbol`
tmeasday b68f6d3
Ensure we teardown when going to missing properly
tmeasday b0dda03
Add a note
tmeasday d586ce7
Don't emit `STORY_PREPARED` in v6 mode.
tmeasday a6d05f4
Don't allow setting args to `undefined`
tmeasday c4a2d6a
Ignore v<3 storyIndexes
tmeasday 01294ff
Ensure we send `args` with `SET_STORIES`
tmeasday fc1b933
Fix storyshots
tmeasday ec3f41e
Revert "Wait a tick before apply arg changes and other re-renders."
tmeasday d4d0863
Get rid of setTimeout(0) and instead just call `renderToDOM` immediately
tmeasday db5cfab
Added a bunch of comments and some READMEs
tmeasday 81838bd
Arg fix `lib/api`
tmeasday 53e00b3
Fix exported type from `.raw()`
tmeasday d9679bb
Refactor to pass sync as an arg rather than using a separate method
tmeasday 18066d0
Add migration notes about new features
tmeasday 18ed032
Merge pull request #15987 from storybookjs/on-demand-store-sync-arg
tmeasday b76e744
Temporarily restore glob-base to fix importFn
shilman 5b5524b
Recompute stories.json on each request in dev-mode
shilman 5c83383
Add warning if find old `stories.json`
tmeasday 9473f4d
Apply suggestions from code review
tmeasday 06c58d9
Add presets for all frameworks
tmeasday 66e226e
Somehow missed this
tmeasday 75bad87
Somehow missed this too
tmeasday 0c7a166
Update most <any> to nothing which defaults to <AnyFramework>
tmeasday ff29a54
Update CSF for `AnyFramework`
tmeasday a0acacc
Use `to-require-context` for glob generation after all
tmeasday 40a4e6c
Merge pull request #16008 from storybookjs/on-demand-store-uncached-s…
tmeasday 5ecdcce
Merge branch 'on-demand-store' into fix/on-demand-store-addon-docs
shilman 58817de
Fix problem with `prepareForInline`
tmeasday 58db776
Update CSF to get rid of play context
tmeasday a1e1ec6
Fix docs rendering
shilman 28d1fe2
Merge branch 'on-demand-store' into fix/on-demand-store-addon-docs
shilman dcdf150
Update store/preview to take project annotations on init.
tmeasday ca4108c
We need to track initialization now.
tmeasday 2c62434
Fix unbalanced hooks error in ArgsTable
shilman c76a842
Update Store APIs to be backwards-compatible
tmeasday ac1b4f5
MDX: Rename mdxComponentMeta to mdxComponentAnnotations
shilman 0ae41ca
Clean up source snippet retrieval for arbitrary stories
shilman 825f435
Fix modern inline rendering with absolutely positioned elements
shilman 5bc3db4
Fix stories.json auto-extraction for named exports
shilman faf1b42
Retain hooks between loads of the story store.
tmeasday c26cd6b
Merge branch 'on-demand-store' into fix/on-demand-store-addon-docs
shilman ebd1f93
Ensure we don't call configure for stories if we don't have any
tmeasday b385392
Hooks order fix
tmeasday 168e546
Add simple docs tab e2e test
shilman 9070630
Wait until all sub-stories have rendered in docs
tmeasday 6af0547
Update snapshots
shilman acf0e9c
Fix deepscan error
shilman 9bb98c9
Ensure we emit all `SNIPPET_RENDERED` in `useEffect()`
tmeasday f2edc58
Fix docs test
shilman 2a16b7a
Update story to new DocsContext
shilman 65be218
Fix tests and ensure channel is defined
tmeasday c4d2507
Fix failing sourceDecorator tests
shilman ed17c1f
Merge pull request #16037 from storybookjs/on-demand-store-fix-useEff…
shilman 84603ec
Merge branch 'on-demand-store' into fix/on-demand-store-addon-docs
shilman adcc98f
E2E force remove package-lock.json
shilman 18f4c71
Addon-docs/web-components: Handle no-manifest version check
shilman 7681f82
Merge pull request #16034 from storybookjs/fix/on-demand-store-addon-…
shilman 5a981b4
Fix deepscan
shilman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see Lodash being used anywhere.