-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Pass proper stack of an error #15864
Conversation
This looks identical to the previous PR you made, #14336. Can you provide an example or detailed steps to reproduce the issue you are having? |
@MichaelArestad @yannbf indeed it is identical, this is the only way I can 'reopen' it, since it was closed. The issue is that (new Error).toString does not contain a stacktrace, but message only. The stack trace is visible after that does not help to solve any problems occured because of the error, as it shows nothing, but the fact that something went wrong and the error message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @extempl! It certainly makes things much better. I simulated this error by calling a function that does not exist in a .stories file.
Here's the result prior to your fix:
Great contribution! 👏
@yannbf any chance you can help get CI to pass? |
Nx Cloud ReportCI ran the following commands for commit 9993215. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
@shilman this seems good to go! |
Reopening #14336
Issue: Stack of an error is not the error's, but the storybook's.
What I did
Pass stack explicitly (toString does not include it).
How to test
If your answer is yes to any of these, please make sure to include it in your PR.