CSF: Infer defaultValue of argtype based on arg #15798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 814a5f8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
Hey @maxmezzomo! Thanks a lot for the previous contribution you did in #14356! I noticed that the autocompletion was not happening from keys that were not defined in the Args, so I added a fix to that. I also thought it would be nice to get type inference from the property (as in What do you think? |
yannbf
changed the title
shilman
changed the title
yannbf
force-pushed
the
feature/argtypes-inference
branch
from
bfc6632 to
814a5f8
Compare
|
@shilman this seems good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension on top of #14356
What I did
ArgTypes is now able to infer the values based on the Args being passed.
If a custom argtype is being passed (that's not a key of passed down Args), it will still infer the correct properties, but
defaultValuewill be of typeunknown.How to test
If your answer is yes to any of these, please make sure to include it in your PR.