Update markdown-to-jsx version to fix url links in comments #15083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14176
What I did
There was an issue with
markdown-to-jsx
, in that it was generating a link twice, whencompodocs
already generated an anchor tag for a given URL string. So whenmarkdown-to-jsx
would see this:It would then generate the following:
As it adds an anchor tag automatically when it sees a URL link in text.
I issued a PR to
markdown-to-jsx
fixing the duplicated nested link issue (quantizor/markdown-to-jsx#381), it was merged a few days ago. This PR updates the version of the library to apply the fix on this side.How to test
storybook/examples/angular-cli/src/stories/basics/ng-module/angular-src/chips-group.component.ts
Line 41 in abc74c3
It could be something like:
angular-cli
example usingyarn storybook
, and go to the ChipsGroup docs page: http://localhost:9008/?path=/docs/basics-ngmodule-module-with-multiple-component--chips-groupa
element present.