Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Support manager build with webpack5 #15001

Merged
merged 26 commits into from
May 24, 2021
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented May 21, 2021

Issue: #14044

NOTE: I released 6.3.0-alpha.37 / 38 / 39 off this feature branch for testing purposes!

What I did

  • Extract manager-webpack4 from core-server
  • Add manager-webpack5 that uses webpack5-compatible plugins
  • Other minor refactors
  • Fix warning ("expected 4, received 4")
  • import * as webpackReal for addons Presets: Expand webpackInstance to include entire namespace #15016
  • Add warning when you don't have manager-webpack5, link to MIGRATION.md

Self-merging @tmeasday @ndelangen @wKich @yannbf

How to test

  • CI passes (ish)
  • Released on alpha & tested in sample app
yarn add @storybook/builder-webpack5 @storybook/manager-webpack5 webpack --dev

Then update .storybook/main.js:

module.exports = {
  core: {
    builder: 'webpack5'
  }
}

@nx-cloud
Copy link

nx-cloud bot commented May 21, 2021

Nx Cloud Report

CI ran the following commands for commit 74079bc. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title Core: Refactor core-server to build manager with webpack4 or 5 Core: Support manager build with webpack5 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants