Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Add undeclared dependency regenerator-runtime #14979

Merged
merged 1 commit into from
May 18, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented May 18, 2021

Issue:

The PnP e2e test started failing in #14945 (cc @shilman)

Fixes https://github.com/yarnpkg/berry/runs/2606936463?check_suite_focus=true#step:5:267

What I did

Add undeclared dependency regenerator-runtime to @storybook/csf-tools

How to test

CI should be green

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2021

Nx Cloud Report

CI ran the following commands for commit 377ebe9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman
Copy link
Member

shilman commented May 18, 2021

Sorry about that @merceyz !!! 🙈

Fix looks good but CI doesn't seem to be fixed

Copy link
Member

@gaetanmaisse gaetanmaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @merceyz!

@shilman CI errors are related to addon-controls cypress tests so we can merge this one ;)

@gaetanmaisse gaetanmaisse changed the title fix(csf): add undeclared dependency regenerator-runtime CSF: Add undeclared dependency regenerator-runtime May 18, 2021
@gaetanmaisse gaetanmaisse merged commit 2ccb609 into storybookjs:next May 18, 2021
@gaetanmaisse gaetanmaisse deleted the merceyz/csf-dependencies branch May 18, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants