Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls: Fix controls without options and add warning #14976

Merged
merged 1 commit into from
May 18, 2021
Merged

Controls: Fix controls without options and add warning #14976

merged 1 commit into from
May 18, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented May 18, 2021 •
edited
Loading

Issue: #14752

What I did

  • Fixed bug that crashes manager when controls are not properly configured
  • Logged a warning to help users track down the problem
  • Added a test story

self-merging @ghengeveld

How to test

See attached story in examples/official-storybook

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 231b114. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit cadd381 into next May 18, 2021
@shilman shilman deleted the 14752-fix-controls-without-options branch May 18, 2021 10:01
@shilman shilman mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: controls bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman