Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add modern build target to apps aka frameworks #14967

Merged
merged 3 commits into from
May 18, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented May 18, 2021

Issue: N/A

Follow-up to #14954

What I did

Add "sbmodern" export to app/**/package.json

How to test

yarn storybook/build-storybook --modern

@shilman shilman added core maintenance User-facing maintenance tasks labels May 18, 2021
@nx-cloud
Copy link

nx-cloud bot commented May 18, 2021

Nx Cloud Report

CI ran the following commands for commit 14ecee1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman requested a review from ndelangen as a code owner May 18, 2021 02:17
@shilman shilman changed the title Core: Add modern build target to apps (frameworks) Core: Add modern build target to apps aka frameworks May 18, 2021
@shilman shilman merged commit 62e741e into next May 18, 2021
@shilman shilman deleted the feat/add-modern-to-apps branch May 18, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant