Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add args enhancers + use in addon-actions #14901

Merged
merged 7 commits into from
May 18, 2021
Merged

Core: Add args enhancers + use in addon-actions #14901

merged 7 commits into from
May 18, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented May 12, 2021 •
edited
Loading

Issue: #14579

Telescoping on #14900

What I did

  • Add argsEnhancers throughout the stack.
  • Use in actions
  • Deprecate argType.defaultValue

@tmeasday tmeasday requested a review from shilman May 12, 2021 06:15
@tmeasday tmeasday changed the title Add args enhancers + use in addons Add args enhancers + use in actons May 12, 2021
@tmeasday tmeasday changed the title Add args enhancers + use in actons Add args enhancers + use in actions May 12, 2021
@nx-cloud
Copy link

nx-cloud bot commented May 12, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 8644131. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@tmeasday tmeasday force-pushed the 14579-remove-default-values branch from f7b43e5 to 7aa36d7 Compare May 14, 2021 04:46
@tmeasday tmeasday force-pushed the 14579-arg-enhancers branch from 6487968 to d271bee Compare May 14, 2021 04:57
@tmeasday tmeasday mentioned this pull request May 14, 2021
Closed
@tmeasday tmeasday force-pushed the 14579-remove-default-values branch from dd543f5 to 9021343 Compare May 14, 2021 05:21
@tmeasday tmeasday force-pushed the 14579-arg-enhancers branch from 6bcc0bc to a74f9d8 Compare May 14, 2021 05:22
Base automatically changed from 14579-remove-default-values to 14579-undefined-inputs May 18, 2021 06:11
shilman
shilman approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 💯

@shilman shilman changed the title Add args enhancers + use in actions Core: Add args enhancers + use in addon-actions May 18, 2021
@shilman shilman merged commit f692020 into 14579-undefined-inputs May 18, 2021
@shilman shilman deleted the 14579-arg-enhancers branch May 18, 2021 06:13
@shilman shilman mentioned this pull request May 18, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
addon: actions core feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman