-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Styling updates #14820
UI: Styling updates #14820
Conversation
Nx Cloud ReportCI ran the following commands for commit 943f762. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
…sign not a piecemeal change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @domyen! 💯
@domyen I think this PR introduces a slight regression. In the case where there's a boolean arg with an |
🤔 |
@domyen I'll keep an eye out for it after the undefined values changes come in and provide a repro if it's still broken then |
Thanks! I handed the undefined state project back to @tmeasday yesterday so he'll probably know if anything is wrong. |
Ok @tmeasday @domyen you can see the changes in every new PR that has unaccepted changes related to this bug. I'm not sure why it didn't show up in the original PR. Example: https://www.chromatic.com/test?appId=5a375b97f4b14f0020b0cda3&id=609673a78e8200003929f724 |
False alarm. It was introduced here: #14408, reverting |
Issue: #14737 and other UI improvements
What I did
True | False
toFalse | True
per Appearance of Boolean controls #14737How to test