Avoid rebinding story during decoration #14677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
requested review from
ndelangen,
theinterned and
usulpro
as code owners
tmeasday
commented
Apr 21, 2021
Comment on lines
145
to
149
| export type DecorateStoryFunction<StoryFnReturnType = unknown> = ( | ||
| storyFn: StoryFn<StoryFnReturnType>, | ||
| decorators: DecoratorFunction<StoryFnReturnType>[] | ||
| decorators: DecoratorFunction<StoryFnReturnType>[], | ||
| getStoryContext: () => StoryContext | ||
| ) => StoryFn<StoryFnReturnType>; |
There was a problem hiding this comment.
I'm not sure if it is an issue that I changed this type here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12255
What I did
Rather than using a closure and rebinding the story function with the
contextas it is decorated, instead use agetStoryContext()function on the store to find out the context of the rendering story.How to test
There is a Chromatic test. Not sure if we need a test for
getStoryContext, it isn't really intended to be used externally.See above.
No