Web-components: Add full reload listening to server-side-events #14445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
requested changes
Apr 8, 2021
| @@ -12,6 +13,6 @@ module.exports = { | |||
| '@storybook/addon-viewport', | |||
| ], | |||
| core: { | |||
| builder: 'webpack4', | |||
| builder: 'webpack5', | |||
There was a problem hiding this comment.
AFAIK we can't use this in the monorepo
shilman
reviewed
Apr 8, 2021
shilman
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
LGTM, thanks @brion-fuller!! @gaetanmaisse the CI results looks like an intermittent NPM failure so I'm merging anyway.
|
Thank you @brion-fuller confirmed this works with vanilla custom elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12307
Web components cannot be hot reloaded as customElement.define can only be called once per page with an unique string. This has been on the users to add to their config file. Now this is available for free.
What I did
I hooked into server-sent events for webpack HMR and listen for the built event in which I trigger a page reload.
How to test
Is this testable with Jest or Chromatic screenshots? no
Does this need a new example in the kitchen sink apps? no
Does this need an update to the documentation? yes