Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Improve docs inline rendering setup #14333

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Angular: Improve docs inline rendering setup #14333

merged 1 commit into from
Mar 26, 2021

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Mar 25, 2021 •
edited
Loading

Issue:

What I did

Re adds the changes made in this PR and revert in this one

But this time adds a Webpack configuration to make @storybook/angular/element-renderer import optional if the sb client does not have the right dependencies

Set up Angular prepareForInline inside the preset. Users can enable it on by simply setting docs.inlineStories: true and we don't need to create another entry point or import in the user's code.
NOTE that this is a breaking change for prerelease users, since this PR removes the unnecessary entry point.

How to test

  • Is this testable with Jest or Chromatic screenshots?

yes it is tested by e2e

  • Does this need a new example in the kitchen sink apps?

N/A

  • Does this need an update to the documentation?

Done

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021 •
edited
Loading

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against 1e20a89

@gaetanmaisse @ThibaudAV
feat(addon-docs): improve inline rendering setup
1e20a89 
Co-authored-by: Gaëtan Maisse <[email protected]>
Co-authored-by: ThibaudAv <[email protected]>
@ThibaudAV ThibaudAV marked this pull request as ready for review March 25, 2021 09:27
@ThibaudAV ThibaudAV requested a review from a team March 25, 2021 09:28
@ThibaudAV ThibaudAV force-pushed the fix-angular-inlinerenderer branch from 0782b12 to 1e20a89 Compare March 25, 2021 09:31
@ThibaudAV ThibaudAV requested a review from gaetanmaisse March 25, 2021 10:04
@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Mar 25, 2021
@shilman shilman added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Mar 26, 2021
@shilman shilman changed the title Angular: improve docs inline rendering setup Angular: Improve docs inline rendering setup Mar 26, 2021
shilman
shilman approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHOA this is awesome -- great job @ThibaudAV 💯

@shilman shilman merged commit 18c1143 into next Mar 26, 2021
@shilman shilman deleted the fix-angular-inlinerenderer branch March 26, 2021 05:36
@ThibaudAV
Copy link
Contributor Author

Made wiith @gaetanmaisse ;)
Thanks @shilman

@ndelangen ndelangen mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@shilman shilman

Labels
addon: docs angular maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaudAV @shilman @gaetanmaisse